gen_stub: Infer constants' types from values #19568
Merged
+40
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
requested review from
kocsismate,
nielsdos,
bukka,
kamil-tekiela,
devnexen,
Girgias and
derickr
as code owners
nielsdos
requested changes
Aug 24, 2025
nielsdos
approved these changes
Aug 25, 2025
Don't require `@var` with a type when the type can be inferred from a literal value in the stub file.
DanielEScherzer
force-pushed
the
gen-stub-infer-const-type
branch
from
09581f3 to
3c2f266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require
@varwith a type when the type can be inferred from a literal value in the stub file.