Skip to content

fix build warnings for Haiku. #19575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build warnings for Haiku. #19575

wants to merge 1 commit into from
+8 −1

Conversation

devnexen
Copy link
Member

especially linker warning about php binary having an executable stack.

petk
petk reviewed Aug 30, 2025
View reviewed changes
petk
petk reviewed Aug 31, 2025
View reviewed changes
@devnexen
fix build warnings for Haiku.
6efe885 
especially linker warning about php binary having an executable stack.
@devnexen devnexen force-pushed the haiku_build_warnings branch from da202e9 to 6efe885 Compare August 31, 2025 14:06
petk
petk approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the configure.ac change, it's all good I think. This could probably also go to PHP-8.3 but ok with master (upcoming PHP 8.5) I guess.

@devnexen
Copy link
Member Author

I struggled with the branch choice but, ultimately, it is border line improvement as php still works despite this linker warning.

@devnexen devnexen requested a review from a team August 31, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petk petk petk approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: sockets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @petk