Skip to content

zend_weakrefs: Remove layer of indirection in zend_weakrefs_hash_clean() #19580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
+17 −15
Merged

zend_weakrefs: Remove layer of indirection in zend_weakrefs_hash_clean() #19580

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4884fec
zend_weakrefs: Remove layer of indirection in `zend_weakrefs_hash_cle…
TimWolla Aug 25, 2025
08de135
zend_weakrefs: Include `zend_weakmap_free_obj()` optimization in `zen…
TimWolla Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Zend/zend_weakrefs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ ZEND_API zend_result zend_weakrefs_hash_del(HashTable *ht, zend_object *key) {
ZEND_API void zend_weakrefs_hash_clean(HashTable *ht) {
zend_ulong obj_key;
ZEND_HASH_FOREACH_NUM_KEY(ht, obj_key) {
zend_weakrefs_hash_del(ht, zend_weakref_key_to_object(obj_key));
/* Call zend_weakref_unregister to avoid an unneccessary
* zend_hash_index_find lookup in zend_weakrefs_hash_del. */
zend_weakref_unregister(zend_weakref_key_to_object(obj_key), ZEND_WEAKREF_ENCODE(ht, ZEND_WEAKREF_TAG_BARE_HT), 1);
} ZEND_HASH_FOREACH_END();
}

Expand Down