Skip to content

zend_string: Support NUL bytes in ZSTR_*_LITERAL() and zend_string_*literal*() #19582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

zend_string: Support NUL bytes in ZSTR_*_LITERAL() and zend_string_*literal*() #19582

merged 1 commit into from
Sep 25, 2025

Conversation

TimWolla
Copy link
Member

Following #19565 (comment).

@TimWolla TimWolla requested a review from a team August 25, 2025 09:16
@TimWolla TimWolla force-pushed the zstr-init-literal-nul branch from 5addc69 to c76cf66 Compare August 25, 2025 09:19
DanielEScherzer
DanielEScherzer reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm around a -0.5 on this generally, and maybe -0.75 on this for PHP 8.5 - @edorian, what do you think?

@TimWolla TimWolla marked this pull request as draft August 25, 2025 09:47
@TimWolla TimWolla force-pushed the zstr-init-literal-nul branch from c76cf66 to d7bfdcc Compare August 25, 2025 09:52
@TimWolla TimWolla changed the title zend_string: Support NUL bytes in ZSTR_INIT_LITERAL() zend_string: Support NUL bytes in ZSTR_*_LITERAL() and zend_string_*literal*() Aug 25, 2025
@iluuu1994
Copy link
Member

As the person who introduced ZSTR_INIT_LITERAL(), restricting it to actual string literals makes sense to me. Whether this should be delayed to 8.6 is at the RMs discretion.

@TimWolla TimWolla force-pushed the zstr-init-literal-nul branch from d7bfdcc to 3ba7252 Compare August 27, 2025 08:25
@TimWolla TimWolla force-pushed the zstr-init-literal-nul branch from 3ba7252 to bc11b01 Compare September 24, 2025 07:01
@TimWolla TimWolla marked this pull request as ready for review September 24, 2025 07:02
@TimWolla TimWolla force-pushed the zstr-init-literal-nul branch from bc11b01 to e2743a5 Compare September 24, 2025 08:12
@TimWolla TimWolla requested a review from iluuu1994 September 24, 2025 08:50
@TimWolla TimWolla merged commit 5d431d0 into php:master Sep 25, 2025
8 of 9 checks passed
@TimWolla TimWolla deleted the zstr-init-literal-nul branch September 25, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielEScherzer DanielEScherzer DanielEScherzer left review comments

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos is a code owner

Assignees

No one assigned

Labels

ABI break Category: Engine Extension: dom Extension: zend_test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimWolla @iluuu1994 @Girgias @DanielEScherzer