Skip to content

Conversation

devnexen
Copy link
Member

No description provided.

@Girgias Girgias requested a review from a team September 3, 2025 09:03
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM review - code looks good but documentation and tests would be appreciated

- PDO_PGSQL: Constants related to transaction states have been deprecated :
PDO::PGSQL_TRANSACTION_IDLE, PDO::PGSQL_TRANSACTION_ACTIVE, PDO::PGSQL_TRANSACTION_INTRANS,
PDO::PGSQL_TRANSACTION_INERROR, PDO::PGSQL_TRANSACTION_UNKNOWN.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a link to the RFC

UPGRADING Outdated
PDO::SQLITE_OPEN_CREATE => Pdo\Sqlite::OPEN_CREATE
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_driver_specific_pdo_constants_and_methods

- PDO_PGSQL: Constants related to transaction states have been deprecated :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- PDO_PGSQL: Constants related to transaction states have been deprecated :
- PDO_PGSQL: Constants related to transaction states have been deprecated:

@devnexen devnexen merged commit 9f8802c into php:master Sep 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants