Deprecate driver specific PDO methods #19596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
force-pushed
the
pdo-deprecations-methods
branch
from
3044969 to
776cfa2
Compare
Girgias
approved these changes
Aug 26, 2025
mvorisek
reviewed
Aug 26, 2025
Co-authored-by: Michael Voříšek <[email protected]>
devnexen
approved these changes
Aug 27, 2025
DanielEScherzer
approved these changes
Aug 28, 2025
| pefree(func, 1); | ||
| } | ||
| /* }}} */ | ||
|
|
||
| /* We cannot add #[Deprecated] attributes in @generate-function-entries stubs, |
There was a problem hiding this comment.
oh? Why not? Can you expand no this a bit?
If the support from gen_stub is missing I can try to add it
There was a problem hiding this comment.
I've expanded a bit when replying to @mvorisek above: #19596 (comment)
Possibly we could improve that a little by adding support for attributes to zend_function_entry, expose a function that copies zend_function_entry attributes to a zend_function, and use that in pdo_dbh.c.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the "Deprecate driver specific PDO methods" part of https://wiki.php.net/rfc/deprecations_php_8_5.
Constants were handled in #19526.