main: Deprecate deriving $_SERVER['argc'] and $_SERVER['argv'] from the query string #19606
+185
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
force-pushed
the
argc-argv-from-query
branch
from
6900d7e to
c1f22ff
Compare
derickr
reviewed
Aug 27, 2025
main/php_variables.c
Outdated
| @@ -886,6 +891,7 @@ static bool php_auto_globals_create_server(zend_string *name) | |||
| zend_hash_update(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]), ZSTR_KNOWN(ZEND_STR_ARGC), argc); | |||
| } | |||
| } else { | |||
| zend_error(E_DEPRECATED, "Deriving $_SERVER['argc'] and $_SERVER['argv'] from $_SERVER['QUERY_STRING'] is deprecated, configure register_argc_argv=0 to suppress this message and access the query parameters via $_SERVER['QUERY_STRING'] or $_GET"); | |||
There was a problem hiding this comment.
This is a nit, but this should be two sentences:
Deriving $_SERVER['argc'] and $_SERVER['argv'] from $_SERVER['QUERY_STRING'] is deprecated. Configure register_argc_argv=0 to suppress this message and access the query parameters via $_SERVER['QUERY_STRING'] or $_GET
(ie, a deprecated. Configure instead of a deprecated, configure)
TimWolla
force-pushed
the
argc-argv-from-query
branch
from
c1f22ff to
090baf3
Compare
TimWolla
force-pushed
the
argc-argv-from-query
branch
2 times, most recently
from
90a3ccd to
6086512
Compare
This INI is ignored since the previous commit, which makes the hardcoded setting obsolete.
TimWolla
force-pushed
the
argc-argv-from-query
branch
from
6086512 to
85f7cb1
Compare
| } | ||
| } else if (PG(register_argc_argv)) { | ||
| zend_error(E_DEPRECATED, "Deriving $_SERVER['argc'] and $_SERVER['argv'] from $_SERVER['QUERY_STRING'] is deprecated, configure register_argc_argv=0 to suppress this message and access the query parameters via $_SERVER['QUERY_STRING'] or $_GET"); |
There was a problem hiding this comment.
Trying to make the message shorter while still accurate.
Accessing the query parameters might be a bad suggestion (as that might reintroduce the security issue)
Suggested change
| zend_error(E_DEPRECATED, "Deriving $_SERVER['argc'] and $_SERVER['argv'] from $_SERVER['QUERY_STRING'] is deprecated, configure register_argc_argv=0 to suppress this message and access the query parameters via $_SERVER['QUERY_STRING'] or $_GET"); | |
| zend_error(E_DEPRECATED, "Deriving $_SERVER['argv'] from the query string is deprecated, configure register_argc_argv=0 to turn this off."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_register_argc_argv_ini_directive