Skip to content

ext/standard: Fix GH-19610 (Deprecation warnings in functions taking as argument) #19611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

ext/standard: Fix GH-19610 (Deprecation warnings in functions taking as argument) #19611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ PHP NEWS
- Session:
. Fix RC violation of session SID constant deprecation attribute. (ilutov)

- Standard:
. Fix GH-19610 (Deprecation warnings in functions taking as argument).
(Girgias)

- URI:
. Fixed memory management of Uri\WhatWg\Url objects. (timwolla)
. Fixed memory management of the internal "parse_url" URI parser.
Expand Down
2 changes: 2 additions & 0 deletions Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7800,6 +7800,8 @@ static void zend_compile_params(zend_ast *ast, zend_ast *return_type_ast, uint32
ZSTR_VAL(name));
} else if (zend_string_equals(name, ZSTR_KNOWN(ZEND_STR_THIS))) {
zend_error_noreturn(E_COMPILE_ERROR, "Cannot use $this as parameter");
} else if (zend_string_equals_literal(name, "http_response_header")) {
CG(context).has_assigned_to_http_response_header = true;
}

if (op_array->fn_flags & ZEND_ACC_VARIADIC) {
Expand Down
14 changes: 14 additions & 0 deletions ext/standard/tests/http/http_response_header_deprecated_parameter.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
--TEST--
$http_reponse_header as a parameter name should not warn
--FILE--
<?php

function foo($http_response_header) {
var_dump($http_response_header);
}

foo("OK");

?>
--EXPECT--
string(2) "OK"