Skip to content

random: Use ->default_object_handlers for engines #19625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

random: Use ->default_object_handlers for engines #19625

merged 1 commit into from
Aug 29, 2025
+14 −7

Conversation

TimWolla
Copy link
Member

No description provided.

@TimWolla TimWolla requested review from nielsdos and a team August 28, 2025 22:04
@TimWolla TimWolla requested a review from zeriyoshi as a code owner August 28, 2025 22:04
zeriyoshi
zeriyoshi approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@zeriyoshi zeriyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DanielEScherzer
DanielEScherzer approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for php_random_engine_common_init -is:fork -is:archived in GitHub yields 21 files, so this is not going to have a big BC break. RM approval, technical review not performed

@TimWolla TimWolla merged commit fc467dc into php:master Aug 29, 2025
9 checks passed
@TimWolla TimWolla deleted the random-default-object-handlers branch August 29, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@zeriyoshi zeriyoshi zeriyoshi approved these changes

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

Assignees
No one assigned
Labels
ABI break Extension: random
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimWolla @nielsdos @zeriyoshi @DanielEScherzer