zend_ast: Mark zend_ast_list_add() as ZEND_ATTRIBUTE_NODISCARD
#19632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually caught a bug in the implementation of attributes on regular constants: A list of 4 constants with an attribute did not correctly result in an error, since the reallocated list wasn't stored anywhere.
devnexen
reviewed
Aug 29, 2025
Co-authored-by: David CARLIER <[email protected]>
devnexen
reviewed
Aug 29, 2025
devnexen
approved these changes
Aug 29, 2025
DanielEScherzer
approved these changes
Aug 29, 2025
| @@ -2956,7 +2956,7 @@ zend_ast * ZEND_FASTCALL zend_ast_with_attributes(zend_ast *ast, zend_ast *attr) | |||
| /* Since constants are already stored in a list, just add the attributes | |||
| * to that list instead of storing them elsewhere; | |||
| * zend_compile_const_decl() checks the kind of the list elements. */ | |||
| zend_ast_list_add(ast, attr); | |||
| ast = zend_ast_list_add(ast, attr); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.