Skip to content

zend_ast: Fix Closure scope for FCC in constant expression #19639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

zend_ast: Fix Closure scope for FCC in constant expression #19639

merged 3 commits into from
Sep 1, 2025

Conversation

TimWolla
Copy link
Member

Fixes #19637

@TimWolla TimWolla requested review from edorian and iluuu1994 August 30, 2025 16:53
iluuu1994
iluuu1994 approved these changes Aug 31, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. The class should be cached through the GET_CE_CACHE() mechanism.

@TimWolla
Copy link
Member Author

The class should be cached through the GET_CE_CACHE() mechanism.

Will look into that later.

@iluuu1994
Copy link
Member

Will look into that later.

I was just confirming this should already work (stupid ambiguous English language 😄).

@TimWolla TimWolla merged commit c93b467 into php:master Sep 1, 2025
9 checks passed
@TimWolla TimWolla deleted the gh19637-closure-scope branch September 1, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@edorian edorian edorian approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Closure scope for FCC in constant expression
3 participants
@TimWolla @iluuu1994 @edorian