Fix closing title tag #19643
Closed
Fix closing title tag #19643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
Author
|
Ah, I missed this. Any reason this wasn't merged? |
Member
Because it's been ages since I looked at it, and as phar is not maintained by anyone with deep enough phar knowledge it's hard to judge the correctness. |
Member
Author
|
Ok. So maybe the simple, manual fix is acceptable? |
Member
If you get CI green yes ;) |
Merged
Unfortunately, ext/phar/stub.h and ext/phar/makestub.php seem to be out of sync, so ext/phar/stub.h was adjusted manually. This should be fixed separately. See phpGH-19633
iluuu1994
force-pushed
the
closing-title-tag
branch
from
42109b5 to
1d434bb
Compare
Member
|
Obsoleted via my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, ext/phar/stub.h and ext/phar/makestub.php seem to be out of sync, so ext/phar/stub.h was adjusted manually. This should be fixed separately.
See GH-19633