[WIP] cURL Socket Functions #19656
Draft
[WIP] cURL Socket Functions #19656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
commented
Sep 1, 2025
| php_stream *p_stream; | ||
|
|
||
| if (stream == NULL && what != CURL_POLL_REMOVE) { | ||
| p_stream = (void*) php_stream_fopen_from_fd(socket, "rw", NULL); |
There was a problem hiding this comment.
This should probably be read only.
krakjoe
force-pushed
the
krakjoe/curl-socket-functions
branch
from
48ebc7b to
5842e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request was made to expose cURL sockets to userland so they may be used in external event loops.
The original request suggested we use curls export of fdsets, this looked pretty restricted though when I came to implement it, and exporting the set for every select also didn't look very performant.
cURL has provided these API's for a long time, a very long time, and we have never implemented them, I'm not certain of the reasons for that.
This has reintroduced resources in cURL, but there's no other reasonable way to do this ...
To opt-in to socket management you must set a timer and socket function.
I'm not certain about this at all, looking for feedback on this approach.
I'm not certain of the consequences of manipulating these streams outside of select(), what happens if you read or write them is unclear.