GH-19691: Add asymmetric visibility to Reflection::getModifierNames()
#19697
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Sep 4, 2025
| case ZEND_ACC_PRIVATE_SET: | ||
| add_next_index_stringl(return_value, "private(set)", sizeof("private(set)")-1); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Likely needs ZEND_ACC_PUBLIC_SET for public public(set) readonly.
There was a problem hiding this comment.
I tested that and it just returned public and readonly though, just without the protected(set)
There was a problem hiding this comment.
case ZEND_ACC_PUBLIC_SET:
/* Unreachable */
break;
as implicit documentation?
There was a problem hiding this comment.
Ah, right. I forgot this is removed at compile time. The flag being absent makes sense for getModifiers, though it's a bit confusing here...
iluuu1994
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.