gen_stub: various simplifications and clean up (6) #19699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of global functions by moving it to instance method `FileInfo::generateArgInfoCode()`. In the process, make the following parts of `FileInfo` private: - `$funcInfos` - `$generateFunctionEntries` - `$declarationPrefix` - `$generateClassEntries` - `::getMinimumPhpVersionIdCompatibility()`
arnaud-lb
approved these changes
Sep 4, 2025
| $this->attributes = $attributes; | ||
| $this->framelessFunctionInfos = $framelessFunctionInfos; | ||
| $this->exposedDocComment = $exposedDocComment; | ||
| if ($return->tentativeReturnType && $this->isFinalMethod()) { |
There was a problem hiding this comment.
I like the intent, but IMHO the method has the advantage of putting a name on the expression ($this->flags & Modifiers::FINAL) || ($this->classFlags & Modifiers::FINAL).
kocsismate
reviewed
Sep 27, 2025
| } | ||
|
|
||
| return true; | ||
| return !array_any($this->types, static fn (SimpleType $type) => !$type->isScalar()); |
There was a problem hiding this comment.
nit: just for the sake of completeness, it would be nice to add return type for the callables
kocsismate
reviewed
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit can be reviewed independently, and should have no functional changes