Skip to content

Conversation

alexandre-daubois
Copy link
Member

Addresses #19238 (comment)

@TimWolla
Copy link
Member

TimWolla commented Sep 8, 2025

By changing the global to zend_string* rather than char* (requires OnUpdateStr), the actual usage can also use the zend_string API.

@alexandre-daubois
Copy link
Member Author

PR updated to use zend_string where possible

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix Niels' remark when you touch this anyways.

@alexandre-daubois alexandre-daubois merged commit 3f66cbe into php:master Sep 9, 2025
9 checks passed
@alexandre-daubois alexandre-daubois deleted the cr-lf-mode-validation branch September 9, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants