Skip to content

Fix memory leak when providing an invalid locale to IntlDateFormatter #19764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Fix memory leak when providing an invalid locale to IntlDateFormatter #19764

merged 1 commit into from
Sep 9, 2025

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Sep 8, 2025 •
edited
Loading

Introduced in #19593 but only leaking from PHP 8.4.

@alexandre-daubois alexandre-daubois marked this pull request as ready for review September 8, 2025 18:29
devnexen
devnexen approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx !

@alexandre-daubois alexandre-daubois merged commit b718514 into php:PHP-8.4 Sep 9, 2025
9 checks passed
alexandre-daubois added a commit that referenced this pull request Sep 9, 2025
@alexandre-daubois
Merge branch 'PHP-8.4'
5a177ee 
* PHP-8.4:
  Fix memory leak when providing an invalid locale to IntlDateFormatter (#19764)
  Fix intl tests naming (#19763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@devnexen devnexen devnexen approved these changes

Assignees

No one assigned

Labels

Extension: intl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandre-daubois @NattyNarwhal @devnexen