ext/ldap: [RFC] Deprecate build with Oracle Instance Client version. #19809
+65
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not know if I need any more warning in other places. There does not seem any CI for using Oracle Instant Client. |
nielsdos
reviewed
Sep 12, 2025
ext/ldap/ldap.c
Outdated
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| zend_error(E_DEPRECATED, "Calling ldap_connect_wallet is deprecated"); |
There was a problem hiding this comment.
I guess you should consistently use () when referring to a function name. You did so on line 976 but not here.
There was a problem hiding this comment.
Also this should use the #[\Deprecated] attribute in the stub instead of triggering this in C.
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
4975330 to
5132197
Compare
nielsdos
approved these changes
Sep 12, 2025
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
6cd78fc to
3b22db1
Compare
17 tasks
DanielEScherzer
approved these changes
Sep 19, 2025
| GSLC_SSL_NO_UATH | ||
| GSLC_SSL_ONEWAY_UATH | ||
| GSLC_SSL_TWOWAY_UATH | ||
|
|
UPGRADING
Outdated
Comment on lines
441
to
442
| ldap_connect with wallet support | ||
| ldap_connect_wallet |
There was a problem hiding this comment.
Suggested change
| ldap_connect with wallet support | |
| ldap_connect_wallet | |
| ldap_connect() with wallet support | |
| ldap_connect_wallet() |
ext/ldap/config.m4
Outdated
| elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.12.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.12.1; then | ||
| PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) | ||
| AC_DEFINE([HAVE_ORALDAP], [1]) | ||
| AC_MSG_WARN([Build with Oracle Instant Client is deprecated]) |
There was a problem hiding this comment.
should we include the version of the deprecation here? I'm not familiar with the SOP for deprecations in the build configurations so if that isn't standard no need to include it
There was a problem hiding this comment.
No that s a good point I ll add the version
devnexen
force-pushed
the
deprecate_oracle_ldap
branch
from
3b22db1 to
3efb7f2
Compare
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.