Skip to content

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Sep 13, 2025

This makes the DOM classes the only classes that only have __sleep() magic methods, and __wakeup() methods without a corresponding __unserialize() magic method, as it is needed to allow serialization of child classes.

@Girgias
Copy link
Member Author

Girgias commented Sep 15, 2025

I am closing this as the reason for __wakeup() to exist is to verify the type of the message and code properties. As those would, hopefully, use actual property types in PHP 9 we can then just remove the __wakeup() method as it will then serve no purpose.

@Girgias Girgias closed this Sep 15, 2025
@Girgias Girgias deleted the exceptions-unserialize-magicmethod branch September 15, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant