Patch #20028 Flaky tests on PHP-8.3 #20035
Open
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in [RunningTests], tests have to be written to be independent of any php.ini file. As the tests are based on counting the line terminators, the mail.add_x_header php.ini setting has to be off. Fix is to set `mail.add_x_header` to `off`. [RunningTests]: docs/source/miscellaneous/running-tests.rst fix-up-of: phpGH-8086
As documented in [RunningTests], tests have to be written to be independent of any php.ini file. Without specifying the timezone, the var_dump() will make use of the default timezone that may not be the expected "UTC" timezone. This renders the test-cases flaky and will make them fail if the `date.timezone` is different from the string "UTC". Fix is to interpolate the timezone in the test fixture or to set `date.timezone` to `UTC`. [RunningTests]: docs/source/miscellaneous/running-tests.rst fix-up-of: phpGH-18624
As documented in [RunningTests], tests have to be written to be independent of any php.ini file. Without specifying that no errors should be logged, the php cli server invocation with the invalid address provokes additional diagnostic PHP Warning messages on the diagnostic channel which invalidates the EXPECTF section. This renders the test-case flaky and will make it fail unless `log_errors` is `0`. Fix is to set the directive on the command line. [RunningTests]: docs/source/miscellaneous/running-tests.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky tests on PHP 8.3. /cc @bukka
As learned in #18286 a couple of tests were flaky. These are the fixes for them based on PHP-8.3 plus those which are for flaky tests that then were discovered on PHP-8.3 to be flaky.
Fixes only.