Skip to content

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Oct 3, 2025

No description provided.

@devnexen devnexen marked this pull request as ready for review October 4, 2025 08:09
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this one. It makes the code needlessly harder to understand / easier to introduce bugs. For php_converter_from_u_callback() specifically it also looks like zargs[2] could also avoid the dtor'ing, which is a case in point.

In fact, I would even rewrite that to:

        for (size_t i = 0; i < countof(zargs); i++) {
            zval_ptr_dtor(&zargs[i]);
        }

to make it even more robust.

@devnexen
Copy link
Member Author

devnexen commented Oct 4, 2025

zargs[0] was the most straightforward to address, I do not see as harder to understand tough ? one needless call I m for it in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants