ext/pgsql: Refactor parameter parsing to remove manual usage of zend_wrong_parameters_count_error() #20068
+89
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blerg, really can't wait to get rid of this jank... |
Girgias
force-pushed
the
pgsql-zpp-refacto
branch
from
8a745ec to
346df2d
Compare
nielsdos
requested changes
Oct 5, 2025
| if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET, ZEND_NUM_ARGS(), "P|z", &file_in, &oid) == SUCCESS) { | ||
| link = FETCH_DEFAULT_LINK(); | ||
| CHECK_DEFAULT_LINK(link); | ||
| goto fn_body; |
There was a problem hiding this comment.
It would be great if this goto could be avoided.
| Z_PARAM_LONG(result_type) | ||
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| php_pgsql_fetch_hash(return_value, result, row, row_is_null, result_type); |
There was a problem hiding this comment.
row isn't initialized but is passed to this function, this is UB.
| Z_PARAM_LONG_OR_NULL(row, row_is_null) | ||
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| php_pgsql_fetch_hash(return_value, result, row, row_is_null, PGSQL_ASSOC); |
There was a problem hiding this comment.
row isn't initialized but is passed to this function, this is UB.
| Z_PARAM_LONG(result_type) | ||
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| php_pgsql_fetch_hash(return_value, result, row, row_is_null, result_type); |
There was a problem hiding this comment.
row isn't initialized but is passed to this function, this is UB.
| must be allowed for compatibility */ | ||
| php_pgsql_fetch_hash(INTERNAL_FUNCTION_PARAM_PASSTHRU, PGSQL_ASSOC, 1); | ||
| zval dataset; | ||
| php_pgsql_fetch_hash(&dataset, result, row, row_is_null, PGSQL_ASSOC); |
There was a problem hiding this comment.
row isn't initialized but is passed to this function, this is UB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract pgsql changes from #20066