Fix GH-17346: PDOStatement::$queryString "readonly" is not properly implemented #20111
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y implemented We shouldn't use a cache slot while writing as it would allow to bypass the custom "read only" behaviour. (Note that this is not a "real" readonly, it is more like a "writeonce")
TimWolla
reviewed
Oct 8, 2025
| ?> | ||
| --FILE-- | ||
| <?php | ||
| $stmt = new PDOStatement(); |
There was a problem hiding this comment.
Why is it even legal to manually construct a PDOStatement?! I'm not sure if this is worth fixing, since for “properly created” PDOStatements writing just fails.
In fact, can't we just make it properly readonly?
There was a problem hiding this comment.
The answer to both your questions appears to be: mocking, see https://bugs.php.net/81084
There was a problem hiding this comment.
The answer to both your questions appears to be: mocking, see
sigh
Then we might be able to public public(set) readonly nowadays?
There was a problem hiding this comment.
Or alternatively making it public protected(set) readonly (i.e. readonly) and asking folks to go through Reflection for this kind of use case might also be okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use a cache slot while writing as it would allow to bypass the custom "read only" behaviour. (Note that this is not a "real" readonly, it is more like a "writeonce")