Fix GH-19817: Decode SCRIPT_FILENAME issue in php 8.5 #20114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes default for fastcgi.script_path_encoded INI to have default behavior without a BC break. There has been already issue about this in RC so it is very likely that it could have much bigger impact so it's better to be safe.
|
@php/release-managers-85 This is a change of INI introduced in PHP 8.5. It should be less risky so I think it's safer for the release. Please approve if you are cool with it. |
|
This is really more regression actually so no need for you to approve as it's really a bug fix so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes default for fastcgi.script_path_encoded INI to have default behavior without a BC break. There has been already issue about this in RC so it is very likely that it could have much bigger impact so it's better to be safe.