Fix shm corruption with coercion in options of unserialize() #20129
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Oct 11, 2025
| Shm corruption with coercion in options of unserialize() | ||
| --FILE-- | ||
| <?php | ||
| unserialize("{}", ["allowed_classes" => [0]]); |
There was a problem hiding this comment.
What happens if you have a non-stringable object as an option?
There was a problem hiding this comment.
In the sense that it will throw and exit out at the check after the loop
There was a problem hiding this comment.
Cool that's the thing I was wondering about.
| convert_to_string(entry); | ||
| lcname = zend_string_tolower(Z_STR_P(entry)); | ||
| /* Note: cannot use zval_get_tmp_string() here as we need to keep it in class_hash for longer than this loop. */ | ||
| zend_string *str = zval_get_string(entry); |
There was a problem hiding this comment.
Any reason for not using the try version of this API?
There was a problem hiding this comment.
Possible, but not necessary, as we will exit at the exception check a bit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.