Fix arginfo/zpp violations when LIBXML_SCHEMAS_ENABLED is not available #20130
+10
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, we move the macro check and therefore we also have to move some variable declarations to avoid compiler warnings.
nielsdos
force-pushed
the
xml-reader-stub-arginfo-zpp
branch
from
1a2ba7a to
8d70430
Compare
Girgias
approved these changes
Oct 11, 2025
Comment on lines
924
to
-929
| PHP_METHOD(XMLReader, setSchema) | ||
| { | ||
| #ifdef LIBXML_SCHEMAS_ENABLED |
There was a problem hiding this comment.
That the method need to exist? As normally we only expose functions/methods for functionality that is available. Obviously this is not a fix that is possible for 8.3.
There was a problem hiding this comment.
Normally we should make the method conditionally available indeed. As atm it is hard to polyfill this.
There are more of these kind of cases unfortunately. We should try to make an effort to find them on master and do the right thing there. That's not very high priority though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, we move the macro check and therefore we also have to move some variable declarations to avoid compiler warnings.