Add extra checks to Phar::mungServer() #20141
Conversation
| } else if (zend_string_equals_literal(Z_STR_P(data), "SCRIPT_FILENAME")) { | ||
| PHAR_G(phar_SERVER_mung_list) |= PHAR_MUNG_SCRIPT_FILENAME; | ||
| } else { | ||
| zend_throw_exception_ex(phar_ce_PharException, 0, "Invalid value passed to Phar::mungServer(), expecting an array of any of these strings: PHP_SELF, REQUEST_URI, SCRIPT_FILENAME, SCRIPT_NAME"); |
There was a problem hiding this comment.
Maybe this should be a ValueError as this is a programming error? Also specify the argument number of the array param
There was a problem hiding this comment.
as well, above should have been a TypeError it seems.
There was a problem hiding this comment.
phar is full of custom exceptions. Just looking at phar_object.c reveals several instances of BadMethodCallException for example which should ideally have been a ValueError [1], e.g. zend_throw_exception_ex(spl_ce_BadMethodCallException, 0, "Unknown compression type specified");.
[1] Of course, phar predates ValueError etc...
If we want to make proper use of Value/TypeError in phar we should do an entire pass over the extension so it all remains internally consistent, rather than doing it on a case per case basis.
3 participants
No description provided.