Fixes for the nightly workflow to upgrade to macOS 15 #20161
Merged
+10
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al() function that may be overriden for valgrind (php#13099) This is a more safely way to fix phpGH-9068
iluuu1994
approved these changes
Oct 13, 2025
ramsey
approved these changes
Oct 15, 2025
|
Looks good to me. You have my approval to merge this into PHP-8.1. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
lc_ctype_inheritance.phpttest on macOS 15 and above. It fails on macOS 15 as it inheritsLC_CTYPEinto the thread locale. We can skip the test on macOS 15 as the issue is a due to a change by Apple as discussed in str_word_count behaves differently on macos 14 vs 15+ #19828.For RMs, This will unblock #20159 for the upgrade in nightly workflow to macOS 15 after macOS 13 has been deprecated.
(actions/runner-images#13046)