Fix missing deprecation message for default case statement followed by semicolon #20172
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Oct 15, 2025
…y semicolon Follow-up to phpGH-19215
theodorejb
force-pushed
the
fix-missing-deprecation
branch
from
5bb7c95 to
70e31e5
Compare
TimWolla
approved these changes
Oct 15, 2025
|
Is there anything else that needs to happen before this can be merged? |
|
Given this is borderline between a bugfix and a feature (it will emit additional warnings that were not there before) and we're in RC, the RMs both want to have a look. I've already messaged Daniel in private so that it hopefully gets looked at before Tuesday when the next RC is tagged. |
|
For what it's worth - this PR is in response to a question about this deprecation asked on the Internals mailing list, so Internals should be considered informed and there have been no objections on the mailing list against this PR. |
DanielEScherzer
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to GH-19215