uri: Improve type safety for php_uri_parser_rfc3986_userinfo_*()
#20244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
changed the title
php_uri_parser_rfc3986_*()php_uri_parser_rfc3986_userinfo_*()
The signature for these functions does not need to match a specific function pointer signature, thus there is no need for a `void*` to take the uri.
TimWolla
force-pushed
the
uri-rfc3986-userinfo-void
branch
from
a81d77e to
77fd515
Compare
kocsismate
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature for these functions does not need to match a specific function pointer signature, thus there is no need for a
void*to take the uri.