Use MYSQL_TYPE constants instead of FIELD_TYPE #20249
Open
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
requested review from
SakiTakamachi and
kamil-tekiela
as code owners
| switch (type) { | ||
| PDO_MYSQL_NATIVE_TYPE_NAME(STRING) | ||
| PDO_MYSQL_NATIVE_TYPE_NAME(VAR_STRING) | ||
| #ifdef FIELD_TYPE_TINY |
There was a problem hiding this comment.
Don't you need to replace these as well?
|
Ah darn it, those are part of an enum so you can't ifdef them... |
nielsdos
force-pushed
the
fix-mysql-type
branch
from
a854305 to
e0f5635
Compare
The FIELD_TYPE constants are for BC. The JSON/VECTOR types are not defined in FIELD_TYPE for libmysqlclient. MYSQL_TYPE is available since MYSQL 5.0.0, so switch to that. Since MYSQL_TYPEs are enums and not defines, we need version checks instead. JSON was added in mysql 8.0.0 in mysql/mysql-server@c24045514581 VECTOR was added in mysql 9.0.0 in mysql/mysql-server@8cd51511de7d Replaces phpGH-20245.
nielsdos
force-pushed
the
fix-mysql-type
branch
from
e0f5635 to
0c81682
Compare
mvorisek
reviewed
Oct 21, 2025
ext/pdo_mysql/mysql_statement.c
Outdated
| PDO_MYSQL_NATIVE_TYPE_NAME(VECTOR) | ||
| #endif | ||
| #ifdef FIELD_TYPE_JSON | ||
| #if MYSQL_VERSION_ID >= 80000 || defined(PDO_USE_MYSQLND) |
There was a problem hiding this comment.
The JSON type was added in MySQL 5.7.8.
There was a problem hiding this comment.
Huh indeed. Thanks. Looks like it got backported in mysql/mysql-server@3e14f9f in 5.7.8, adjusting again...
JSON support was backported via mysql/mysql-server@3e14f9f in 5.7.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FIELD_TYPE constants are for BC. The JSON/VECTOR types are not
defined in FIELD_TYPE for libmysqlclient.
MYSQL_TYPE is available since MYSQL 5.0.0, so switch to that.
Since MYSQL_TYPEs are enums and not defines, we need version checks
instead.
JSON was added in mysql 8.0.0 in mysql/mysql-server@c24045514581
VECTOR was added in mysql 9.0.0 in mysql/mysql-server@8cd51511de7d
Replaces GH-20245.