Remove useless zend_exception_save() from ZEND_THROW #20256
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're executing in the VM, so EG(exception) has to be unset. ZEND_THROW itself already has HANDLE_EXCEPTION() calls when it throws, i.e. when the subject is not a throwable object.
TimWolla
reviewed
Oct 22, 2025
| ZEND_ASSERT(!EG(exception)); | ||
| Z_TRY_ADDREF_P(value); | ||
| zend_throw_exception_object(value); | ||
| zend_exception_restore(); |
There was a problem hiding this comment.
Should the restore also be removed?
There was a problem hiding this comment.
I thought EG(prev_exception) could be set, but I'll double check. zend_exception_save() is called in very few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're executing in the VM, so EG(exception) has to be unset. ZEND_THROW itself already has HANDLE_EXCEPTION() calls when it throws, i.e. when the subject is not a throwable object.