phar: use SOURCE_DATE_EPOCH to build PHAR when available
#20570
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Nov 24, 2025
Comment on lines
+452
to
+454
| if (tloc) { | ||
| *tloc = ts; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't understand the API of this function:
- it returns a value?
- it overwrites a reference, if given?
- it uses an environment variable, if given?
I'd say that a rename (for clarity) would be a good idea, and the parameter can perhaps be always gone?
ndossche
requested changes
Nov 24, 2025
|
|
||
| static inline time_t source_date_epoch_time(time_t *tloc) | ||
| { | ||
| const char *sde; |
Member
There was a problem hiding this comment.
Please merge the declarations and assignments, we no longer do C89
| return PHAR_G(cached_fp)[entry->phar->phar_pos].manifest[entry->manifest_pos].offset; | ||
| } | ||
|
|
||
| static inline time_t source_date_epoch_time(time_t *tloc) |
Member
There was a problem hiding this comment.
As pointed out by Ocramius, this argument seems not useful.
|
|
||
| tsrm_env_lock(); | ||
| sde = getenv("SOURCE_DATE_EPOCH"); | ||
| ts = (sde) ? strtoul(sde, NULL, 10) : time(0); |
Member
There was a problem hiding this comment.
Suggested change
| ts = (sde) ? strtoul(sde, NULL, 10) : time(0); | |
| ts = (sde) ? strtoul(sde, NULL, 10) : time(NULL); |
| time_t ts; | ||
|
|
||
| tsrm_env_lock(); | ||
| sde = getenv("SOURCE_DATE_EPOCH"); |
Member
There was a problem hiding this comment.
You should use php_getenv, which will do the right thing on Windows and also take care of locking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I recently discovered the project https://stagex.tools/ and out of curiosity I checked how the PHP package (https://codeberg.org/stagex/stagex/src/branch/staging/packages/core/php-zts) was built. This is how I discovered those two potential interesting patches (credits to @zeroware) that could easily be merged in the PHP distribution.
I proposed the adoption of those patches to the Nix community as well at NixOS/nixpkgs#463814
I hope the branch
PHP-8.3is the correct one, let me know if there's anything to change.Links:
This PR:
SOURCE_DATE_EPOCH(the file datetime) inside the PHAR only when it is available.