Saner string to number comparison #3886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikic are you planning on moving this forward? From what I recall, the feedback on PHP internals was mostly positive. |
nikic
force-pushed
the
string-to-number-comparison
branch
from
9909de2 to
e828da5
Compare
nikic
force-pushed
the
string-to-number-comparison
branch
from
6282c23 to
7d8012a
Compare
nikic
force-pushed
the
string-to-number-comparison
branch
from
7d8012a to
e5c5d15
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for RFC https://wiki.php.net/rfc/string_to_number_comparison.