Detecting if we are debugged BSD/MacOS. #4367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
check_debugged_process_osx_bsd
branch
from
6875ed6 to
dfffd2c
Compare
Checking the proc title might be enough.
devnexen
force-pushed
the
check_debugged_process_osx_bsd
branch
from
dfffd2c to
7d783ba
Compare
devnexen
changed the title
|
This is still waiting on review after 3 years. Who's the best person to review this? |
|
I'm going to close this: It was opened a long time ago and the current code seems to deal with at least one of the cases it covers (zend_gdb.c supports FreeBSD in supported branches). If there is still something missing (I suspect there may be), please open a fresh pull with the necessary changes for the target. This pull in it's current form doesn't look useful, but that's not to say that the idea in general has no merit or shouldn't be done. On a side note, I see the suggested code is specifically looking for gdb. I think lldb is much more widely used on macos, it may be time we add lldb specific stuff to make it as useful as gdb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.