Skip to content

Promote notices to warnings #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Promote notices to warnings #4764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0f8cb14
Convert notices to warnings
nikic Oct 1, 2019
8995a27
Update Zend tests
nikic Oct 1, 2019
f176c69
Update tests/
nikic Oct 1, 2019
f349d51
Update PCRE tests
nikic Oct 1, 2019
57ba169
Update other tests
nikic Oct 1, 2019
a1420b3
Fixup
nikic Oct 1, 2019
82052e8
Update opcache tests
nikic Oct 1, 2019
a907105
Fix i386 tests, hopefully
nikic Oct 1, 2019
7311c81
More i386 fixes
nikic Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
216 changes: 108 additions & 108 deletions Zend/tests/019.phpt
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 16 additions & 16 deletions Zend/tests/024.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,43 +15,43 @@ var_dump($a->$b->{$c[1]});

?>
--EXPECTF--
Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d
NULL

Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d

Notice: Undefined variable: c in %s on line %d
Warning: Undefined variable: c in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d
NULL

Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d
int(1)

Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d

Notice: Undefined variable: b in %s on line %d
Warning: Undefined variable: b in %s on line %d
int(0)

Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d
NULL

Notice: Undefined variable: b in %s on line %d
Warning: Undefined variable: b in %s on line %d
int(1)

Notice: Trying to get property '1' of non-object in %s on line %d
Warning: Trying to get property '1' of non-object in %s on line %d
NULL

Notice: Trying to get property '1' of non-object in %s on line %d
Warning: Trying to get property '1' of non-object in %s on line %d
NULL

Notice: Undefined variable: c in %s on line %d
Warning: Undefined variable: c in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to get property '1' of non-object in %s on line %d
Warning: Trying to get property '1' of non-object in %s on line %d

Notice: Trying to get property '' of non-object in %s on line %d
Warning: Trying to get property '' of non-object in %s on line %d
NULL
2 changes: 1 addition & 1 deletion Zend/tests/026.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ print "ok\n";

?>
--EXPECTF--
Notice: Trying to get property 'a' of non-object in %s on line %d
Warning: Trying to get property 'a' of non-object in %s on line %d
ok
Attempt to assign property 'a' of non-object
ok
38 changes: 19 additions & 19 deletions Zend/tests/033.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,42 +25,42 @@ try {

?>
--EXPECTF--
Notice: Undefined variable: arr in %s on line %d
Warning: Undefined variable: arr in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Undefined variable: arr in %s on line %d
Warning: Undefined variable: arr in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Undefined variable: arr in %s on line %d
Warning: Undefined variable: arr in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to access array offset on value of type null in %s on line %d
Warning: Trying to access array offset on value of type null in %s on line %d

Notice: Trying to get property 'foo' of non-object in %s on line %d
Warning: Trying to get property 'foo' of non-object in %s on line %d
Attempt to assign property 'foo' of non-object
Attempt to assign property 'bar' of non-object
4 changes: 2 additions & 2 deletions Zend/tests/array_unpack/undef_var.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ array unpacking with undefinded variable
var_dump([...$arr]);

--EXPECTF--
Notice: Undefined variable: arr in %s on line %d
Warning: Undefined variable: arr in %s on line %d

Fatal error: Uncaught Error: Only arrays and Traversables can be unpacked in %s:%d
Stack trace:
#0 {main}
thrown in %s on line %d
thrown in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/arrow_functions/002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ var_dump((fn() => $b + $c)());

?>
--EXPECTF--
Notice: Undefined variable: c in %s on line %d
Warning: Undefined variable: c in %s on line %d
int(1)
4 changes: 2 additions & 2 deletions Zend/tests/arrow_functions/003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ var_dump($fn());

?>
--EXPECTF--
Notice: Undefined variable: a in %s on line %d
Warning: Undefined variable: a in %s on line %d
NULL

Notice: Undefined variable: 5 in %s on line %d
Warning: Undefined variable: 5 in %s on line %d
NULL
2 changes: 1 addition & 1 deletion Zend/tests/assign_to_var_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var_dump($var1);
echo "Done\n";
?>
--EXPECTF--
Notice: Trying to access array offset on value of type float in %s on line %d
Warning: Trying to access array offset on value of type float in %s on line %d
NULL
NULL
Done
2 changes: 1 addition & 1 deletion Zend/tests/bug29674.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ $obj->printVars();
===BASE===
string(4) "Base"

Notice: Undefined property: BaseClass::$private_child in %sbug29674.php on line %d
Warning: Undefined property: BaseClass::$private_child in %s on line %d
NULL
===CHILD===
string(4) "Base"
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug29689.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ $baz->printFoo();
--EXPECTF--
foo: foo foo2
bar: bar
Notice: Undefined property: bar::$foo2 in %s on line %d
Warning: Undefined property: bar::$foo2 in %s on line %d

---baz--
foo: foo foo2
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug29883.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ bool(false)
bool(true)
bool(true)

Notice: Uninitialized string offset: -10 in %s on line 6
Warning: Uninitialized string offset: -10 in %s on line %d
string(0) ""
string(1) "u"
string(1) "u"
2 changes: 1 addition & 1 deletion Zend/tests/bug29896.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ function GenerateError2($A1)
GenerateError2("Test2");
?>
--EXPECTF--
#0 userErrorHandler(8, Undefined variable: b, %sbug29896.php, 11) called at [%sbug29896.php:11]
#0 userErrorHandler(2, Undefined variable: b, %s, %d) called at [%s:%d]
#1 GenerateError1(Test1) called at [%sbug29896.php:16]
#2 GenerateError2(Test2) called at [%sbug29896.php:19]
2 changes: 1 addition & 1 deletion Zend/tests/bug30162.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var_dump($db);
?>
===DONE===
--EXPECTF--
Notice: Undefined variable: db in %sbug30162.php on line 35
Warning: Undefined variable: db in %s on line %d
NULL
object(hariCow)#%d (2) {
["x"]=>
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug31098.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ok
ok
ok

Notice: Trying to get property 'wrong' of non-object in %s on line %d
Warning: Trying to get property 'wrong' of non-object in %s on line %d
ok

Warning: Illegal string offset 'wrong' in %s on line %d
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug31720.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ try {
?>
===DONE===
--EXPECTF--
Notice: Undefined variable: nonesuchvar in %s on line %d
Warning: Undefined variable: nonesuchvar in %s on line %d
array_walk() expects parameter 2 to be a valid callback, first array member is not a valid class name or object
===DONE===
40 changes: 20 additions & 20 deletions Zend/tests/bug39018.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,44 +62,44 @@ print "\nDone\n";

?>
--EXPECTF--
Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: Uninitialized string offset: %s in %s on line 6
Warning: Uninitialized string offset: %s in %s on line %d

Notice: Uninitialized string offset: 0 in %s on line %d
Warning: Uninitialized string offset: 0 in %s on line %d

Notice: Uninitialized string offset: 0 in %s on line %d
Warning: Uninitialized string offset: 0 in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: Uninitialized string offset: %i in %s on line %d
Warning: Uninitialized string offset: %i in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: Uninitialized string offset: %i in %s on line %d
Warning: Uninitialized string offset: %i in %s on line %d

Notice: Uninitialized string offset: 0 in %s on line %d
Warning: Uninitialized string offset: 0 in %s on line %d

Notice: Uninitialized string offset: 4 in %s on line %d
Warning: Uninitialized string offset: 4 in %s on line %d

Notice: Uninitialized string offset: 4 in %s on line %d
Warning: Uninitialized string offset: 4 in %s on line %d

Notice: Uninitialized string offset: 4 in %s on line %d
Warning: Uninitialized string offset: 4 in %s on line %d

Notice: Uninitialized string offset: 4 in %s on line %d
Warning: Uninitialized string offset: 4 in %s on line %d

Notice: Uninitialized string offset: 4 in %s on line %d
Warning: Uninitialized string offset: 4 in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: Uninitialized string offset: 12 in %s on line %d
Warning: Uninitialized string offset: 12 in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: Uninitialized string offset: 12 in %s on line %d
Warning: Uninitialized string offset: 12 in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d

Notice: String offset cast occurred in %s on line %d
Warning: String offset cast occurred in %s on line %d
b
Done
2 changes: 1 addition & 1 deletion Zend/tests/bug39036.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ var_dump($key);
echo "Done\n";
?>
--EXPECTF--
Notice: Undefined variable: key in %s on line %d
Warning: Undefined variable: key in %s on line %d
NULL
Done
2 changes: 1 addition & 1 deletion Zend/tests/bug39304.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ Bug #39304 (Segmentation fault with list unpacking of string offset)
var_dump($a,$b);
?>
--EXPECTF--
Notice: Uninitialized string offset: 0 in %sbug39304.php on line %d
Warning: Uninitialized string offset: 0 in %s on line %d
NULL
NULL
2 changes: 1 addition & 1 deletion Zend/tests/bug41209.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ echo "Done\n";
--EXPECTF--
Fatal error: Uncaught ErrorException: Undefined variable: id in %s:%d
Stack trace:
#0 %s(%d): env::errorHandler(8, '%s', '%s', 34)
#0 %s(%d): env::errorHandler(2, 'Undefined varia...', '%s', %d)
#1 {main}
thrown in %s on line %d
14 changes: 7 additions & 7 deletions Zend/tests/bug43201.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,29 @@ Notice: Indirect modification of overloaded property Foo::$arr has no effect in

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 14

Notice: Undefined variable: ref in %sbug43201.php on line 14
Warning: Undefined variable: ref in %s on line %d

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17

Notice: Undefined variable: undef in %sbug43201.php on line 16
Warning: Undefined variable: undef in %s on line %d

Notice: Indirect modification of overloaded property Foo::$arr has no effect in %sbug43201.php on line 17
ok
2 changes: 1 addition & 1 deletion Zend/tests/bug44660.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var_dump($a);
?>
--EXPECTF--
--> read access:
Notice: Trying to get property 'p' of non-object in %s on line %d
Warning: Trying to get property 'p' of non-object in %s on line %d

--> direct assignment:
Attempt to assign property 'p' of non-object
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/bug44899.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ echo "\n";
isset
empty

Notice: Undefined property: myclass::$foo in %s on line %d
Warning: Undefined property: myclass::$foo in %s on line %d
empty
4 changes: 2 additions & 2 deletions Zend/tests/bug47109.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ Bug #47109 (Memory leak on $a->{"a"."b"} when $a is not an object)
$a->{"a"."b"};
?>
--EXPECTF--
Notice: Undefined variable: a in %sbug47109.php on line 2
Warning: Undefined variable: a in %s on line %d

Notice: Trying to get property 'ab' of non-object in %sbug47109.php on line 2
Warning: Trying to get property 'ab' of non-object in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/bug51394.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ $a = $empty($b);
--EXPECTF--
Fatal error: Uncaught Exception: error! in %sbug51394.php:%d
Stack trace:
#0 %sbug51394.php(%d): eh(8, 'Undefined varia%s', '%s', %d)
#0 %s(%d): eh(2, 'Undefined varia...', '%s', %d)
#1 {main}
thrown in %sbug51394.php on line %d
Loading