Prepare for PHP 8.1 #6305
Closed
Prepare for PHP 8.1 #6305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also bump API numbers to ensure != from 8.0 ones |
|
You'll also want to clean UPGRADING and UPGRADING.INTERNALS. |
carusogabriel
commented
Oct 9, 2020
Comment on lines
96
to
+100
| var PHP_VERSION = 8; | ||
| var PHP_MINOR_VERSION = 0; | ||
| var PHP_MINOR_VERSION = 1; | ||
| var PHP_RELEASE_VERSION = 0; | ||
| var PHP_EXTRA_VERSION = ""; | ||
| var PHP_VERSION_STRING = "8.0.0"; | ||
| var PHP_VERSION_STRING = "8.1.0"; |
There was a problem hiding this comment.
@cmb69 Let me know if there's something else that needs to be updated on the Windows side :)
nikic
approved these changes
Oct 9, 2020
|
Just checking if |
|
@carusogabriel It's an unrelated failure :) |
|
Maybe temporarily XFAIL bug48097.phpt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a63c99b and the documentation.