Skip to content

Conversation

hwde
Copy link
Contributor

@hwde hwde commented Jul 8, 2022

No description provided.

@cmb69
Copy link
Member

cmb69 commented Jul 8, 2022

cc @bukka

@bukka
Copy link
Member

bukka commented Jul 8, 2022

From a relatively quick look I'm not sure if this is actually safe as some SAPI's (there are also out of tree external SAPI's so this is an external API) might rely on some of the request_info fields (e.g. request_body, post_entry or cookie_data) to be set before activating which this changes. I will need to look properly which I might do sometime after the feature freeze.

@github-actions
Copy link

There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken.

@smuuf
Copy link

smuuf commented May 21, 2025

This is a pretty annoying bug with PHP-FPM 😢 AFAIK docs (still) do say that post_max_size can be specified in .user.ini, but it has no effect in there (as the issue #8157 says).

@dzuelke
Copy link
Contributor

dzuelke commented Jul 22, 2025

@bukka is there a chance to get this looked at again for inclusion in 8.5? ;) Or maybe have a second sapi_module.early_activate() hook for now, that, if it exists, is called instead?

@bukka
Copy link
Member

bukka commented Jul 31, 2025

@dzuelke I thought about this one and looking what can be done about it and another SAPI callback seems like the best way forward. Implemented in #19333 . So closing this one.

@bukka bukka closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants