First stab at a prototype for revamping the download instructions page #1287
+836
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Regression report for commit 909539d is at https://web-php-regression-report-pr-1287.preview.thephp.foundation |
|
🚀 Preview for commit 909539d can be found at https://web-php-pr-1287.preview.thephp.foundation |
shivammathur
force-pushed
the
redesign-downloads-page-prototype
branch
3 times, most recently
from
a12c8bb to
8afa96c
Compare
shivammathur
force-pushed
the
redesign-downloads-page-prototype
branch
from
1d55dfc to
29a7634
Compare
shivammathur
force-pushed
the
redesign-downloads-page-prototype
branch
from
29a7634 to
54114c1
Compare
derickr
force-pushed
the
redesign-downloads-page-prototype
branch
from
54114c1 to
c0a7eda
Compare
derickr
force-pushed
the
redesign-downloads-page-prototype
branch
from
c0a7eda to
29774dc
Compare
shivammathur
force-pushed
the
redesign-downloads-page-prototype
branch
from
a156285 to
6254fd6
Compare
derickr
commented
Aug 12, 2025
| @@ -2,5 +2,5 @@ | |||
| On the command line, run the following commands: | |||
| </p> | |||
| <pre><code class="language-powershell line-numbers"> | |||
| powershell -c "irm https://php.net/downloads/install.ps1 <?= $version; ?> | iex" | |||
| powershell -c "& ([ScriptBlock]::Create((irm 'https://php.net/install/windows.ps1'))) -Version <?= $version; ?>" | |||
There was a problem hiding this comment.
This should be https://www.php.net/install/windows.ps1 to avoid redirects. I'm also thinking that instead of install, the directory should be include/download-instructions, like the other files.
There was a problem hiding this comment.
I've fixed the domain part of this now.
| # Add the packages.sury.org/php repository. | ||
| sudo apt update | ||
| sudo apt install -y curl | ||
| curl -sSL https://packages.sury.org/php/README.txt | sudo bash -x |
There was a problem hiding this comment.
I don't think we should tell users to curl | bash external sources. It's not a great way to teach devs security practises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.