Skip to content

Update prepend.inc add human logic function #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahilespelid
Copy link

it is known that 'is_scalar' does not skip 'null', but the documentation indicates that some resources may be skipped in the future, and since hypothetically a resource can return 'null', the code uses an excessive check for null '$logic_parametr ?? 0'. If you look under the hood of filter_var FILTER_VALIDATE_BOOLEAN, it is known that null returns false, so this construction is '$logic_parametr ?? 0' is redundant and must be replaced by '$logic_parametr'

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, but where should the method added here be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants