Update prepend.inc add human logic function #1308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahilespelid
requested review from
saundefined,
sy-records and
sgolemon
as code owners
sy-records
requested changes
Aug 10, 2025
|
I think we can just close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is known that 'is_scalar' does not skip 'null', but the documentation indicates that some resources may be skipped in the future, and since hypothetically a resource can return 'null', the code uses an excessive check for null '$logic_parametr ?? 0'. If you look under the hood of filter_var FILTER_VALIDATE_BOOLEAN, it is known that null returns false, so this construction is '$logic_parametr ?? 0' is redundant and must be replaced by '$logic_parametr'