Fix mobile navbar sizing #1664
Open
Fix mobile navbar sizing #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imacrayon
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Preview for commit 3baab87 can be found at https://web-php-pr-1664.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit 3baab87 is at https://web-php-regression-report-pr-1664.preview.thephp.foundation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On smaller screen sizes the logo on the PHP 8.5 page gets squished:
This PR cleans up the sizing and spacing of flex items in the navbar so that they maintain their proportions as the navbar shrinks:
The theme button also had and extra right margin on the desktop breakpoint, I removed that so the navbar margin is consistent with other pages.
