[TASK] Refactor isEqualAbsolutePath and isEqualRelativePath into matches

Author: linawolf

packages/guides/src/Compiler/NodeTransformers/MenuNodeTransformers/GlobMenuEntryNodeTransformer.php

@@ -91,6 +91,7 @@ public function getPriority(): int
         return 4500;
     }
 
+    /** @param String[] $globExclude */
     private static function matches(string $actualFile, GlobMenuEntryNode $parsedMenuEntryNode, string $currentFile, array $globExclude): bool
     {
         $expectedFile = $parsedMenuEntryNode->getUrl();

packages/guides/src/Compiler/NodeTransformers/MenuNodeTransformers/InternalMenuEntryNodeTransformer.php

@@ -42,8 +42,7 @@ protected function handleMenuEntry(MenuNode $currentMenu, MenuEntryNode $node, C
         $maxDepth = (int) $currentMenu->getOption('maxdepth', self::DEFAULT_MAX_LEVELS);
         foreach ($documentEntries as $documentEntry) {
             if (
-                !self::isEqualAbsolutePath($documentEntry->getFile(), $node, $currentPath)
-                && !self::isEqualRelativePath($documentEntry->getFile(), $node, $currentPath)
+                !self::matches($documentEntry->getFile(), $node, $currentPath)
             ) {
                 continue;
             }
@@ -73,21 +72,11 @@ protected function handleMenuEntry(MenuNode $currentMenu, MenuEntryNode $node, C
         return [$node];
     }
 
-    private static function isEqualAbsolutePath(string $actualFile, InternalMenuEntryNode $parsedMenuEntryNode, string $currentFile): bool
+    private static function matches(string $actualFile, InternalMenuEntryNode $parsedMenuEntryNode, string $currentFile): bool
     {
         $expectedFile = $parsedMenuEntryNode->getUrl();
-        if (!self::isAbsoluteFile($expectedFile)) {
-            return false;
-        }
-
-        return $expectedFile === '/' . $actualFile;
-    }
-
-    private static function isEqualRelativePath(string $actualFile, InternalMenuEntryNode $menuEntryNode, string $currentFile): bool
-    {
-        $expectedFile = $menuEntryNode->getUrl();
         if (self::isAbsoluteFile($expectedFile)) {
-            return false;
+            return $expectedFile === '/' . $actualFile;
         }
 
         $current = explode('/', $currentFile);