CsvImporter

Author: tatevikg1

resources/translations/messages.en.xlf

@@ -416,6 +416,10 @@
                 <source>Subscriber not found</source>
                 <source>Subscriber not found</source>
             </trans-unit>
+            <trans-unit id="subscription.unexpected_error">
+                <source>Unexpected error: %error%</source>
+                <target>Unexpected error: %error%</target>
+            </trans-unit>
 
         </body>
     </file>

src/Domain/Subscription/Service/CsvImporter.php

@@ -8,13 +8,15 @@
 use PhpList\Core\Domain\Subscription\Model\Dto\ImportSubscriberDto;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use League\Csv\Exception as CsvException;
+use Symfony\Contracts\Translation\TranslatorInterface;
 use Throwable;
 
 class CsvImporter
 {
     public function __construct(
         private readonly CsvRowToDtoMapper $rowMapper,
         private readonly ValidatorInterface $validator,
+        private readonly TranslatorInterface $translator,
     ) {
     }
 
@@ -46,7 +48,9 @@ public function import(string $csvFilePath): array
 
                 $validDtos[] = $dto;
             } catch (Throwable $e) {
-                $errors[$index + 1][] = 'Unexpected error: ' . $e->getMessage();
+                $errors[$index + 1][] = $this->translator->trans('Unexpected error: %error%', [
+                    '%error%' => $e->getMessage()
+                ]);
             }
         }
 

tests/Unit/Domain/Subscription/Service/SubscriberCsvImporterTest.php

@@ -24,31 +24,29 @@ class SubscriberCsvImporterTest extends TestCase
 {
     private SubscriberManager&MockObject $subscriberManagerMock;
     private SubscriberAttributeManager&MockObject $attributeManagerMock;
-    private SubscriptionManager&MockObject $subscriptionManagerMock;
     private SubscriberRepository&MockObject $subscriberRepositoryMock;
     private CsvImporter&MockObject $csvImporterMock;
     private SubscriberAttributeDefinitionRepository&MockObject $attributeDefinitionRepositoryMock;
-    private EntityManagerInterface $entityManager;
     private SubscriberCsvImporter $subject;
 
     protected function setUp(): void
     {
         $this->subscriberManagerMock = $this->createMock(SubscriberManager::class);
         $this->attributeManagerMock = $this->createMock(SubscriberAttributeManager::class);
-        $this->subscriptionManagerMock = $this->createMock(SubscriptionManager::class);
+        $subscriptionManagerMock = $this->createMock(SubscriptionManager::class);
         $this->subscriberRepositoryMock = $this->createMock(SubscriberRepository::class);
         $this->csvImporterMock = $this->createMock(CsvImporter::class);
         $this->attributeDefinitionRepositoryMock = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $this->entityManager = $this->createMock(EntityManagerInterface::class);
+        $entityManager = $this->createMock(EntityManagerInterface::class);
 
         $this->subject = new SubscriberCsvImporter(
             subscriberManager: $this->subscriberManagerMock,
             attributeManager: $this->attributeManagerMock,
-            subscriptionManager: $this->subscriptionManagerMock,
+            subscriptionManager: $subscriptionManagerMock,
             subscriberRepository: $this->subscriberRepositoryMock,
             csvImporter: $this->csvImporterMock,
             attrDefinitionRepository: $this->attributeDefinitionRepositoryMock,
-            entityManager: $this->entityManager,
+            entityManager: $entityManager,
         );
     }