Skip to content

Commit f644a98

Browse files
committed
SubscriberManager
1 parent f134842 commit f644a98

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

resources/translations/messages.en.xlf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,10 @@
412412
<source>Value is required</source>
413413
<target>Value is required</target>
414414
</trans-unit>
415+
<trans-unit id="subscription.subscriber_not_found">
416+
<source>Subscriber not found</source>
417+
<source>Subscriber not found</source>
418+
</trans-unit>
415419

416420
</body>
417421
</file>

src/Domain/Subscription/Service/Manager/SubscriberManager.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,28 @@
1515
use PhpList\Core\Domain\Subscription\Service\SubscriberDeletionService;
1616
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
1717
use Symfony\Component\Messenger\MessageBusInterface;
18+
use Symfony\Contracts\Translation\TranslatorInterface;
1819

1920
class SubscriberManager
2021
{
2122
private SubscriberRepository $subscriberRepository;
2223
private EntityManagerInterface $entityManager;
2324
private MessageBusInterface $messageBus;
2425
private SubscriberDeletionService $subscriberDeletionService;
26+
private TranslatorInterface $translator;
2527

2628
public function __construct(
2729
SubscriberRepository $subscriberRepository,
2830
EntityManagerInterface $entityManager,
2931
MessageBusInterface $messageBus,
3032
SubscriberDeletionService $subscriberDeletionService,
33+
TranslatorInterface $translator
3134
) {
3235
$this->subscriberRepository = $subscriberRepository;
3336
$this->entityManager = $entityManager;
3437
$this->messageBus = $messageBus;
3538
$this->subscriberDeletionService = $subscriberDeletionService;
39+
$this->translator = $translator;
3640
}
3741

3842
public function createSubscriber(CreateSubscriberDto $subscriberDto): Subscriber
@@ -91,7 +95,7 @@ public function markAsConfirmedByUniqueId(string $uniqueId): Subscriber
9195
{
9296
$subscriber = $this->subscriberRepository->findOneByUniqueId($uniqueId);
9397
if (!$subscriber) {
94-
throw new NotFoundHttpException('Subscriber not found');
98+
throw new NotFoundHttpException($this->translator->trans('Subscriber not found'));
9599
}
96100

97101
$subscriber->setConfirmed(true);

tests/Unit/Domain/Subscription/Service/Manager/SubscriberManagerTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use PHPUnit\Framework\TestCase;
1616
use Symfony\Component\Messenger\Envelope;
1717
use Symfony\Component\Messenger\MessageBusInterface;
18+
use Symfony\Component\Translation\Translator;
1819

1920
class SubscriberManagerTest extends TestCase
2021
{
@@ -35,6 +36,7 @@ protected function setUp(): void
3536
entityManager: $this->entityManager,
3637
messageBus: $this->messageBus,
3738
subscriberDeletionService: $subscriberDeletionService,
39+
translator: new Translator('en'),
3840
);
3941
}
4042

0 commit comments

Comments
 (0)