Fix loadFromFile params #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tekiela <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
============================================
+ Coverage 92.00% 92.22% +0.21%
+ Complexity 252 250 -2
============================================
Files 3 3
Lines 663 656 -7
============================================
- Hits 610 605 -5
+ Misses 53 51 -2 |
MauricioFauth
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has confused me in the previous PR. If we are not using
$shpFilethen why is the method pretending to need it? I removed it and made the$dbfFilea param instead of property. At least now it's clear how it's used and why.