Fix #306 - ":=" was not recognized as an operator just like "="

[niconoe-]

Fixes #306 as ":=" was not recognized as an operator just like "=" was.

[niconoe-]

@williamdes This time, I started my branch from 5.8.x 😉

[niconoe-]

@williamdes, about the 2 failing tests, I have the feeling that's not on my hands: could it be the 5.8.x branch already having the issue even without my fix?

Maybe another PR is required before this one (and then, I can rebase) to fix those unit tests?

Thanks.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (88c8314) 97.02% compared to head (0076001) 97.02%.

Additional details and impacted files

@@            Coverage Diff            @@
##              5.8.x     #486   +/-   ##
=========================================
  Coverage     97.02%   97.02%           
  Complexity     2234     2234           
=========================================
  Files            69       69           
  Lines          5144     5144           
=========================================
  Hits           4991     4991           
  Misses          153      153           

Impacted Files	Coverage Δ
src/Components/ArrayObj.php	100.00% <ø> (ø)
src/Components/IndexHint.php	100.00% <ø> (ø)
src/Components/SetOperation.php	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[williamdes]

@williamdes, about the 2 failing tests, I have the feeling that's not on my hands: could it be the 5.8.x branch already having the issue even without my fix?

Maybe another PR is required before this one (and then, I can rebase) to fix those unit tests?

Thanks.

You need to get the target branch right the first time or the CI will be run with the branch of your PR merged into the target branch
That's what created this inconsistent output

Closing and re-opening clears up the CI 🎉

[niconoe-]

@williamdes, about the 2 failing tests, I have the feeling that's not on my hands: could it be the 5.8.x branch already having the issue even without my fix?
Maybe another PR is required before this one (and then, I can rebase) to fix those unit tests?
Thanks.

You need to get the target branch right the first time or the CI will be run with the branch of your PR merged into the target branch That's what created this inconsistent output

Closing and re-opening clears up the CI tada

I'm not sure I get it 😆 . I started from the up-to-date 5.8.x, and the target branch is the same, so I don't understand why there's such issue.

Even with the current failing test, is this OK for you? Or do you need me to fix something?

[williamdes]

I'm not sure I get it . I started from the up-to-date 5.8.x, and the target branch is the same, so I don't understand why there's such issue.

You did open the PR with target to master, so GitHub did an automatic merge with master and ran the CI on the result.

master branch renamed properties to camelCase. That's how I understood what got wrong

Even with the current failing test, is this OK for you? Or do you need me to fix something?

I only see green now 👼🏻