Fix ALTER regression #512
Merged
Fix ALTER regression #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #512 +/- ##
============================================
- Coverage 97.02% 97.02% -0.01%
- Complexity 2233 2236 +3
============================================
Files 69 69
Lines 5150 5144 -6
============================================
- Hits 4997 4991 -6
Misses 153 153
☔ View full report in Codecov by Sentry. |
|
This should go to 5.8.x and then do a fast release for it |
- Fixes phpmyadmin#511 - Reverts phpmyadmin#485 Signed-off-by: Maurício Meneghini Fauth <[email protected]>
MauricioFauth
force-pushed
the
alter-regression
branch
from
9c5fee3 to
adfe314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only parses the token if it is not a string.
ALTER TABLE … MODIFY … ENUM('<reserved_keyword>')is being wrongly parsed #485ALTER TABLE … MODIFY … ENUM('<reserved_keyword>')is being wrongly parsed. #478