Add native param types #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
force-pushed
the
param-types-3
branch
from
206f7a6 to
33be4b1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
=========================================
Coverage 96.45% 96.45%
- Complexity 2150 2152 +2
=========================================
Files 64 64
Lines 5015 5019 +4
=========================================
+ Hits 4837 4841 +4
Misses 178 178 ☔ View full report in Codecov by Sentry. |
kamil-tekiela
force-pushed
the
param-types-3
branch
from
33be4b1 to
e965e09
Compare
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
kamil-tekiela
force-pushed
the
param-types-3
branch
from
e965e09 to
b475467
Compare
williamdes
approved these changes
Jan 13, 2024
MauricioFauth
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still not possible to remove
SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHintbecause ofTokenclass. I don't know how to fix it. @MauricioFauth maybe you have some cool idea?