Add type aliases #522
Closed
Add type aliases #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tekiela <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #522 +/- ##
=========================================
Coverage 96.45% 96.45%
Complexity 2150 2150
=========================================
Files 64 64
Lines 5015 5015
=========================================
Hits 4837 4837
Misses 178 178 ☔ View full report in Codecov by Sentry. |
williamdes
approved these changes
Jan 13, 2024
|
This should go to the QA branch, I can rebase it |
@williamdes I'm gonna merge it to 5.9.x. |
|
Merged 8e9442a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williamdes I don't know if I did this right or how to create tests for this. Can you please check?
Related to phpmyadmin/phpmyadmin#18633 (comment)